Skip to content

Refactor: improve ObjectSerializer#194

Closed
erayaydin wants to merge 1 commit intomainfrom
refactor/modernize-object-serializer
Closed

Refactor: improve ObjectSerializer#194
erayaydin wants to merge 1 commit intomainfrom
refactor/modernize-object-serializer

Conversation

@erayaydin
Copy link
Copy Markdown
Member

Remove auto-generated comments from the ignored ObjectSerializer. Add missing test coverage. Use PHP 8.0+ match keyword instead of switch-case.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Template files and generated files are not in-sync.

Following files do not match corresponding templates:
src/ObjectSerializer.php src/SerializationException.php

To fix this warning, make sure template files are up-to-date, and generate files by running the following command:

bash ./scripts/generate.sh

@github-actions
Copy link
Copy Markdown
Contributor

🟢 Coverage increased by 36.00%

Code Coverage Report

Coverage Report

St. Category Percentage Covered / Total
🔴 Statements 36.00% 1838 / 5106
🔴 Functions 28.25% 670 / 2372
Files Coverage
St. File Methods Statements Total Coverage
🔴 src/Model/BotdBotResult.php 0.00% 0.00% 0.00%
🔴 src/Model/ErrorCode.php 0.00% 0.00% 0.00%
🔴 src/Model/ModelInterface.php 0.00% 0.00% 0.00%
🔴 src/Model/ProxyConfidence.php 0.00% 0.00% 0.00%
🔴 src/Model/VPNConfidence.php 0.00% 0.00% 0.00%

@erayaydin
Copy link
Copy Markdown
Member Author

Closing this PR. global_namespace_import php-cs-fixer rule change touches/changes all source files and is better suited for the v4 migration.

@erayaydin erayaydin closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant